openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mt7601u: add missing release on skb in mt7601u_mcu_msg_send 

In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be
consumed on all execution paths. Release skb before returning if
test_bit() fails.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200718052630.11032-1-navid.emamdoost@gmail.com
This commit is contained in:
Navid Emamdoost 2020-07-18 00:26:29 -05:00 committed by Kalle Valo
parent 3f4600de8c
commit 880e21490b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/mediatek/mt7601u/mcu.c
View File

@ -116,8 +116,10 @@ mt7601u_mcu_msg_send(struct mt7601u_dev *dev, struct sk_buff *skb,
int sent, ret; int sent, ret;
u8 seq = 0; u8 seq = 0;
if (test_bit(MT7601U_STATE_REMOVED, &dev->state)) if (test_bit(MT7601U_STATE_REMOVED, &dev->state)) {
consume_skb(skb);
return 0; return 0;
}
mutex_lock(&dev->mcu.mutex); mutex_lock(&dev->mcu.mutex);