openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/armada: plug leak in dumb_map_offset 

We need to drop the gem bo reference if it's an imported one.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Daniel Vetter 2015-11-23 10:32:43 +01:00 committed by Russell King
parent 7a6f7133c5
commit 8d6185b55c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/armada/armada_gem.c
View File

@ -285,7 +285,7 @@ int armada_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
/* Don't allow imported objects to be mapped */ /* Don't allow imported objects to be mapped */
if (obj->obj.import_attach) { if (obj->obj.import_attach) {
ret = -EINVAL; ret = -EINVAL;
goto err_unlock; goto err_unref;
} }
ret = drm_gem_create_mmap_offset(&obj->obj); ret = drm_gem_create_mmap_offset(&obj->obj);
@ -294,6 +294,7 @@ int armada_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
DRM_DEBUG_DRIVER("handle %#x offset %llx\n", handle, *offset); DRM_DEBUG_DRIVER("handle %#x offset %llx\n", handle, *offset);
} }
err_unref:
drm_gem_object_unreference(&obj->obj); drm_gem_object_unreference(&obj->obj);
err_unlock: err_unlock:
mutex_unlock(&dev->struct_mutex); mutex_unlock(&dev->struct_mutex);