openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

tracing: Fix return value check in trace_benchmark_reg() 

In case of error, the function kthread_run() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().

Link: http://lkml.kernel.org/r/20170112135502.28556-1-weiyj.lk@gmail.com

Cc: stable@vger.kernel.org
Fixes: 81dc9f0e ("tracing: Add tracepoint benchmark tracepoint")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
This commit is contained in:
Wei Yongjun 2017-01-12 13:55:02 +00:00 committed by Steven Rostedt (VMware)
parent eb583cd484
commit 8f0994bb8c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/trace/trace_benchmark.c
View File

@ -175,9 +175,9 @@ int trace_benchmark_reg(void)
bm_event_thread = kthread_run(benchmark_event_kthread, bm_event_thread = kthread_run(benchmark_event_kthread,
NULL, "event_benchmark"); NULL, "event_benchmark");
if (!bm_event_thread) { if (IS_ERR(bm_event_thread)) {
pr_warning("trace benchmark failed to create kernel thread\n"); pr_warning("trace benchmark failed to create kernel thread\n");
return -ENOMEM; return PTR_ERR(bm_event_thread);
} }
return 0; return 0;