openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

s390/3270: fix return value check in tty3270_resize_work() 

In case of error, the function tty3270_alloc_screen() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Wei Yongjun 2013-09-11 06:49:20 +08:00 committed by Martin Schwidefsky
parent 15c03dd485
commit 8f0ba630af
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/s390/char/tty3270.c
View File

@ -810,7 +810,7 @@ static void tty3270_resize_work(struct work_struct *work)
struct winsize ws; struct winsize ws;
screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols); screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols);
if (!screen) if (IS_ERR(screen))
return; return;
/* Switch to new output size */ /* Switch to new output size */
spin_lock_bh(&tp->view.lock); spin_lock_bh(&tp->view.lock);