openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/nouveau: fix reference count leak in nouveau_debugfs_strap_peek 

nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that
increments the reference count. In case of failure, decrement the
ref count before returning the error.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
This commit is contained in:
Aditya Pakki 2020-06-13 20:48:37 -05:00 committed by Ben Skeggs
parent 990a116298
commit 8f29432417
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/nouveau/nouveau_debugfs.c
View File

@ -54,8 +54,10 @@ nouveau_debugfs_strap_peek(struct seq_file *m, void *data)
int ret; int ret;
ret = pm_runtime_get_sync(drm->dev->dev); ret = pm_runtime_get_sync(drm->dev->dev);
if (ret < 0 && ret != -EACCES) if (ret < 0 && ret != -EACCES) {
pm_runtime_put_autosuspend(drm->dev->dev);
return ret; return ret;
}
seq_printf(m, "0x%08x\n", seq_printf(m, "0x%08x\n",
nvif_rd32(&drm->client.device.object, 0x101000)); nvif_rd32(&drm->client.device.object, 0x101000));