openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/tilcdc: panel: Use devm_kzalloc to simplify the error path 

Using the managed variant to allocate the resource makes the code simpler
and less error-prone.

Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Johannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Ezequiel Garcia 2014-09-02 09:51:19 -03:00 committed by Dave Airlie
parent e3a9b04621
commit 971645d1fd
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/tilcdc/tilcdc_panel.c
View File

@ -354,7 +354,7 @@ static int panel_probe(struct platform_device *pdev)
return -ENXIO; return -ENXIO;
} }
panel_mod = kzalloc(sizeof(*panel_mod), GFP_KERNEL); panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
if (!panel_mod) if (!panel_mod)
return -ENOMEM; return -ENOMEM;
@ -391,7 +391,6 @@ static int panel_probe(struct platform_device *pdev)
display_timings_release(panel_mod->timings); display_timings_release(panel_mod->timings);
fail_free: fail_free:
kfree(panel_mod);
tilcdc_module_cleanup(mod); tilcdc_module_cleanup(mod);
return ret; return ret;
} }
@ -405,7 +404,6 @@ static int panel_remove(struct platform_device *pdev)
tilcdc_module_cleanup(mod); tilcdc_module_cleanup(mod);
kfree(panel_mod->info); kfree(panel_mod->info);
kfree(panel_mod);
return 0; return 0;
} }