openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

can: usb_8dev: don't touch skb after netif_rx() 

There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Bernd Krumboeck <b.krumboeck@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Marc Kleine-Budde 2015-07-11 21:16:08 +02:00
parent 43c021e8d6
commit 9b721a4cef
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/can/usb/usb_8dev.c
View File

@ -461,10 +461,9 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv,
priv->bec.txerr = txerr; priv->bec.txerr = txerr;
priv->bec.rxerr = rxerr; priv->bec.rxerr = rxerr;
netif_rx(skb);
stats->rx_packets++; stats->rx_packets++;
stats->rx_bytes += cf->can_dlc; stats->rx_bytes += cf->can_dlc;
netif_rx(skb);
} }
/* Read data and status frames */ /* Read data and status frames */
@ -494,10 +493,9 @@ static void usb_8dev_rx_can_msg(struct usb_8dev_priv *priv,
else else
memcpy(cf->data, msg->data, cf->can_dlc); memcpy(cf->data, msg->data, cf->can_dlc);
netif_rx(skb);
stats->rx_packets++; stats->rx_packets++;
stats->rx_bytes += cf->can_dlc; stats->rx_bytes += cf->can_dlc;
netif_rx(skb);
can_led_event(priv->netdev, CAN_LED_EVENT_RX); can_led_event(priv->netdev, CAN_LED_EVENT_RX);
} else { } else {