From 9d8a20a52cd760d1a8739fc408e68617f9d6577b Mon Sep 17 00:00:00 2001 From: Peter Huewe Date: Mon, 29 Oct 2012 22:18:05 +0100 Subject: [PATCH] staging/rtl8192e: Fix compile warning 'is static but declared in .. which is not static' When compiling this driver I get these compile warnings: rtllib.h:2573:2: warning: '______f' is static but declared in inline function 'rtllib_is_empty_essid' which is not static [enabled by default] rtllib.h:2579:3: warning: '______f' is static but declared in inline function 'rtllib_is_empty_essid' which is not static [enabled by default] rtllib.h:2594:2: warning: '______f' is static but declared in inline function 'rtllib_is_valid_mode' which is not static [enabled by default] rtllib.h:2599:2: warning: '______f' is static but declared in inline function 'rtllib_is_valid_mode' which is not static [enabled by default] rtllib.h:2604:2: warning: '______f' is static but declared in inline function 'rtllib_is_valid_mode' which is not static [enabled by default] rtllib.h:2618:3: warning: '______f' is static but declared in inline function 'rtllib_get_hdrlen' which is not static [enabled by default] rtllib.h:2620:3: warning: '______f' is static but declared in inline function 'rtllib_get_hdrlen' which is not static [enabled by default] These functions are declared as extern inline but not 'overloaded' anywhere so we can declare them static inline and get rid of the warnings. Signed-off-by: Peter Huewe Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtllib.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 9ac8d8ea4ae8..3485ef1dfab1 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -2567,7 +2567,7 @@ static inline void *rtllib_priv(struct net_device *dev) return ((struct rtllib_device *)netdev_priv(dev))->priv; } -extern inline int rtllib_is_empty_essid(const char *essid, int essid_len) +static inline int rtllib_is_empty_essid(const char *essid, int essid_len) { /* Single white space is for Linksys APs */ if (essid_len == 1 && essid[0] == ' ') @@ -2583,7 +2583,7 @@ extern inline int rtllib_is_empty_essid(const char *essid, int essid_len) return 1; } -extern inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode) +static inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode) { /* * It is possible for both access points and our device to support @@ -2609,7 +2609,7 @@ extern inline int rtllib_is_valid_mode(struct rtllib_device *ieee, int mode) return 0; } -extern inline int rtllib_get_hdrlen(u16 fc) +static inline int rtllib_get_hdrlen(u16 fc) { int hdrlen = RTLLIB_3ADDR_LEN;