openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/amd/display: fix crash/reboot while accessing sysfs files 

read/writes to aux_dpcd_* sysfs entries leads to system
reboot or hang.
Hence fix the handling of input data and reporting of errors
appropriately to the user space.

Signed-off-by: Shirish S <shirish.s@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Shirish S 2020-09-17 14:07:32 +05:30 committed by Alex Deucher
parent 59d7115dae
commit 9de9a54aba
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
View File

@ -908,7 +908,7 @@ static ssize_t dp_dpcd_address_write(struct file *f, const char __user *buf,
struct amdgpu_dm_connector *connector = file_inode(f)->i_private; struct amdgpu_dm_connector *connector = file_inode(f)->i_private;
if (size < sizeof(connector->debugfs_dpcd_address)) if (size < sizeof(connector->debugfs_dpcd_address))
return 0; return -EINVAL;
r = copy_from_user(&connector->debugfs_dpcd_address, r = copy_from_user(&connector->debugfs_dpcd_address,
buf, sizeof(connector->debugfs_dpcd_address)); buf, sizeof(connector->debugfs_dpcd_address));
@ -923,7 +923,7 @@ static ssize_t dp_dpcd_size_write(struct file *f, const char __user *buf,
struct amdgpu_dm_connector *connector = file_inode(f)->i_private; struct amdgpu_dm_connector *connector = file_inode(f)->i_private;
if (size < sizeof(connector->debugfs_dpcd_size)) if (size < sizeof(connector->debugfs_dpcd_size))
return 0; return -EINVAL;
r = copy_from_user(&connector->debugfs_dpcd_size, r = copy_from_user(&connector->debugfs_dpcd_size,
buf, sizeof(connector->debugfs_dpcd_size)); buf, sizeof(connector->debugfs_dpcd_size));
@ -943,8 +943,8 @@ static ssize_t dp_dpcd_data_write(struct file *f, const char __user *buf,
struct dc_link *link = connector->dc_link; struct dc_link *link = connector->dc_link;
uint32_t write_size = connector->debugfs_dpcd_size; uint32_t write_size = connector->debugfs_dpcd_size;
if (size < write_size) if (!write_size || size < write_size)
return 0; return -EINVAL;
data = kzalloc(write_size, GFP_KERNEL); data = kzalloc(write_size, GFP_KERNEL);
if (!data) if (!data)
@ -967,7 +967,7 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,
struct dc_link *link = connector->dc_link; struct dc_link *link = connector->dc_link;
uint32_t read_size = connector->debugfs_dpcd_size; uint32_t read_size = connector->debugfs_dpcd_size;
if (size < read_size) if (!read_size || size < read_size)
return 0; return 0;
data = kzalloc(read_size, GFP_KERNEL); data = kzalloc(read_size, GFP_KERNEL);