openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

i2c: xiic: Support forcing single-master in DT 

I2C master operating in multimaster mode can get stuck
indefinitely if I2C start is detected on bus, but no master
has a transaction going.

This is a weakness in I2C standard, which defines no way
to recover, since all masters are indefinitely disallowed
from interrupting the currently operating master. A start
condition can be created for example by an electromagnetic
discharge applied near physical I2C lines. Or a already
operating master could get reset immediately after sending
a start.

If it is known during device tree creation that only a single
I2C master will be present on the bus, this deadlock of the
I2C bus could be avoided in the driver by ignoring the
bus_is_busy register of the xiic, since bus can never be
reserved by any other master.

This patch adds this support for detecting single-master flag
in device tree and when provided, improves I2C reliability by
ignoring the therefore unnecessary xiic bus_is_busy register.

Error can be reproduced by pulling I2C SDA -line temporarily low
by shorting it to ground, while linux I2C master is operating on
it using the xiic driver. The application using the bus will
start receiving linux error code 16: "Device or resource busy"
indefinitely:

kernel: pca953x 0-0020: failed writing register
app: Error writing file, error: 16

With multi-master disabled device will instead receive error
code 5: "I/O error" while SDA is grounded, but recover normal
operation once short is removed.

kernel: pca953x 0-0020: failed reading register
app: Error reading file, error: 5

Signed-off-by: Jaakko Laine <ext-jaakko.laine@vaisala.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Jaakko Laine 2020-08-27 17:48:48 +03:00 committed by Wolfram Sang
parent 9106e45cea
commit 9e3b184b3b
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/i2c/busses/i2c-xiic.c
View File

@ -59,6 +59,7 @@ enum xiic_endian {
* @endianness: big/little-endian byte order * @endianness: big/little-endian byte order
* @clk: Pointer to AXI4-lite input clock * @clk: Pointer to AXI4-lite input clock
* @state: See STATE_ * @state: See STATE_
* @singlemaster: Indicates bus is single master
*/ */
struct xiic_i2c { struct xiic_i2c {
struct device *dev; struct device *dev;
@ -74,6 +75,7 @@ struct xiic_i2c {
enum xiic_endian endianness; enum xiic_endian endianness;
struct clk *clk; struct clk *clk;
enum xilinx_i2c_state state; enum xilinx_i2c_state state;
bool singlemaster;
}; };
@ -526,6 +528,15 @@ static int xiic_busy(struct xiic_i2c *i2c)
if (i2c->tx_msg) if (i2c->tx_msg)
return -EBUSY; return -EBUSY;
/* In single master mode bus can only be busy, when in use by this
* driver. If the register indicates bus being busy for some reason we
* should ignore it, since bus will never be released and i2c will be
* stuck forever.
*/
if (i2c->singlemaster) {
return 0;
}
/* for instance if previous transfer was terminated due to TX error /* for instance if previous transfer was terminated due to TX error
* it might be that the bus is on it's way to become available * it might be that the bus is on it's way to become available
* give it at most 3 ms to wake * give it at most 3 ms to wake
@ -811,6 +822,9 @@ static int xiic_i2c_probe(struct platform_device *pdev)
goto err_clk_dis; goto err_clk_dis;
} }
i2c->singlemaster =
of_property_read_bool(pdev->dev.of_node, "single-master");
/* /*
* Detect endianness * Detect endianness
* Try to reset the TX FIFO. Then check the EMPTY flag. If it is not * Try to reset the TX FIFO. Then check the EMPTY flag. If it is not