openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/amd/powerplay: fix static checker warnings in smu7_hwmgr.c 

variable dereferenced before check it

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Rex Zhu 2016-10-11 18:51:16 +08:00 committed by Alex Deucher
parent e07053241b
commit 9faa6b0277
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
View File

@ -3802,13 +3802,15 @@ static inline bool smu7_are_power_levels_equal(const struct smu7_performance_lev
int smu7_check_states_equal(struct pp_hwmgr *hwmgr, const struct pp_hw_power_state *pstate1, const struct pp_hw_power_state *pstate2, bool *equal) int smu7_check_states_equal(struct pp_hwmgr *hwmgr, const struct pp_hw_power_state *pstate1, const struct pp_hw_power_state *pstate2, bool *equal)
{ {
const struct smu7_power_state *psa = cast_const_phw_smu7_power_state(pstate1); const struct smu7_power_state *psa;
const struct smu7_power_state *psb = cast_const_phw_smu7_power_state(pstate2); const struct smu7_power_state *psb;
int i; int i;
if (pstate1 == NULL || pstate2 == NULL || equal == NULL) if (pstate1 == NULL || pstate2 == NULL || equal == NULL)
return -EINVAL; return -EINVAL;
psa = cast_const_phw_smu7_power_state(pstate1);
psb = cast_const_phw_smu7_power_state(pstate2);
/* If the two states don't even have the same number of performance levels they cannot be the same state. */ /* If the two states don't even have the same number of performance levels they cannot be the same state. */
if (psa->performance_level_count != psb->performance_level_count) { if (psa->performance_level_count != psb->performance_level_count) {
*equal = false; *equal = false;