mirror of https://gitee.com/openkylin/linux.git
dmaengine: img-mdc: Remove unnecessary synchronize_irq() before devm_free_irq()
Calling synchronize_irq() right before devm_free_irq() is quite useless. On one hand the IRQ can easily fire again before devm_free_irq() is entered, on the other hand devm_free_irq() itself calls synchronize_irq() internally (in a race condition free way), before any state associated with the IRQ is freed. Patch was generated using the following semantic patch: // <smpl> @@ expression irq, dev; @@ -synchronize_irq(irq); devm_free_irq(dev, irq, ...); // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
parent
1f281792f6
commit
9ff68186ea
|
@ -979,7 +979,6 @@ static int mdc_dma_remove(struct platform_device *pdev)
|
||||||
vc.chan.device_node) {
|
vc.chan.device_node) {
|
||||||
list_del(&mchan->vc.chan.device_node);
|
list_del(&mchan->vc.chan.device_node);
|
||||||
|
|
||||||
synchronize_irq(mchan->irq);
|
|
||||||
devm_free_irq(&pdev->dev, mchan->irq, mchan);
|
devm_free_irq(&pdev->dev, mchan->irq, mchan);
|
||||||
|
|
||||||
tasklet_kill(&mchan->vc.task);
|
tasklet_kill(&mchan->vc.task);
|
||||||
|
|
Loading…
Reference in New Issue