openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ds2782_battery: Fix clientdata on removal 

Probably due to a copy & paste bug, clientdata was set again to the data
structure (which is freed immediately afterwards) when it should be
NULLed. Just remove the calls as the i2c-core does this automatically
now.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ryan Mallon <ryan@bluewatersys.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
This commit is contained in:
Wolfram Sang 2010-04-01 12:27:44 +02:00 committed by Anton Vorontsov
parent db217dece3
commit a009d29ea1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/power/ds2782_battery.c
View File

@ -236,8 +236,6 @@ static int ds2782_battery_remove(struct i2c_client *client)
idr_remove(&battery_id, info->id); idr_remove(&battery_id, info->id);
mutex_unlock(&battery_lock); mutex_unlock(&battery_lock);
i2c_set_clientdata(client, info);
kfree(info); kfree(info);
return 0; return 0;
} }
@ -289,7 +287,6 @@ static int ds2782_battery_probe(struct i2c_client *client,
fail_register: fail_register:
kfree(info->battery.name); kfree(info->battery.name);
fail_name: fail_name:
i2c_set_clientdata(client, info);
kfree(info); kfree(info);
fail_info: fail_info:
mutex_lock(&battery_lock); mutex_lock(&battery_lock);