openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

sd: don't use scsi_setup_blk_pc_cmnd for flush requests 

Simplify handling of flush requests by setting up the command directly
instead of initializing request fields and then calling
scsi_setup_blk_pc_cmnd to propagate the information into the command.

Also rename scsi_setup_flush_cmnd to sd_setup_flush_cmnd for consistency.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
This commit is contained in:
Christoph Hellwig 2014-06-28 12:08:05 +02:00
parent 5158a899d8
commit a118c6c1d9
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/scsi/sd.c
View File

@ -844,14 +844,20 @@ static int sd_setup_write_same_cmnd(struct scsi_device *sdp, struct request *rq)
return ret; return ret;
} }
static int scsi_setup_flush_cmnd(struct scsi_device *sdp, struct request *rq) static int sd_setup_flush_cmnd(struct scsi_cmnd *cmd)
{ {
rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER; struct request *rq = cmd->request;
rq->retries = SD_MAX_RETRIES;
rq->cmd[0] = SYNCHRONIZE_CACHE;
rq->cmd_len = 10;
return scsi_setup_blk_pc_cmnd(sdp, rq); /* flush requests don't perform I/O, zero the S/G table */
memset(&cmd->sdb, 0, sizeof(cmd->sdb));
cmd->cmnd[0] = SYNCHRONIZE_CACHE;
cmd->cmd_len = 10;
cmd->transfersize = 0;
cmd->allowed = SD_MAX_RETRIES;
rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
return BLKPREP_OK;
} }
static void sd_uninit_command(struct scsi_cmnd *SCpnt) static void sd_uninit_command(struct scsi_cmnd *SCpnt)
@ -891,7 +897,7 @@ static int sd_init_command(struct scsi_cmnd *SCpnt)
ret = sd_setup_write_same_cmnd(sdp, rq); ret = sd_setup_write_same_cmnd(sdp, rq);
goto out; goto out;
} else if (rq->cmd_flags & REQ_FLUSH) { } else if (rq->cmd_flags & REQ_FLUSH) {
ret = scsi_setup_flush_cmnd(sdp, rq); ret = sd_setup_flush_cmnd(SCpnt);
goto out; goto out;
} }
ret = scsi_init_io(SCpnt, GFP_ATOMIC); ret = scsi_init_io(SCpnt, GFP_ATOMIC);