openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

sunvdc: Do not spin in an infinite loop when vio_ldc_send() returns EAGAIN 

__vdc_tx_trigger should only loop on EAGAIN a finite
number of times.

See commit adddc32d6f ("sunvnet: Do not spin in an
infinite loop when vio_ldc_send() returns EAGAIN") for detail.

Signed-off-by: Young Xiao <YangX92@hotmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Young Xiao 2018-11-28 12:36:39 +00:00 committed by Jens Axboe
parent 5f0ed774ed
commit a11f6ca9ae
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/block/sunvdc.c
View File

@ -45,6 +45,8 @@ MODULE_VERSION(DRV_MODULE_VERSION);
#define WAITING_FOR_GEN_CMD 0x04 #define WAITING_FOR_GEN_CMD 0x04
#define WAITING_FOR_ANY -1 #define WAITING_FOR_ANY -1
#define VDC_MAX_RETRIES 10
static struct workqueue_struct *sunvdc_wq; static struct workqueue_struct *sunvdc_wq;
struct vdc_req_entry { struct vdc_req_entry {
@ -431,6 +433,7 @@ static int __vdc_tx_trigger(struct vdc_port *port)
.end_idx = dr->prod, .end_idx = dr->prod,
}; };
int err, delay; int err, delay;
int retries = 0;
hdr.seq = dr->snd_nxt; hdr.seq = dr->snd_nxt;
delay = 1; delay = 1;
@ -443,6 +446,8 @@ static int __vdc_tx_trigger(struct vdc_port *port)
udelay(delay); udelay(delay);
if ((delay <<= 1) > 128) if ((delay <<= 1) > 128)
delay = 128; delay = 128;
if (retries++ > VDC_MAX_RETRIES)
break;
} while (err == -EAGAIN); } while (err == -EAGAIN);
if (err == -ENOTCONN) if (err == -ENOTCONN)