nfc: s3fwrn5: Release the nfc firmware

add the code to release the nfc firmware when the firmware image size is
wrong.

Fixes: c04c674fad ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201213095850.28169-1-bongsu.jeon@samsung.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Bongsu Jeon 2020-12-13 18:58:50 +09:00 committed by Jakub Kicinski
parent 8163962aad
commit a4485baefa
1 changed files with 3 additions and 1 deletions

View File

@ -293,8 +293,10 @@ int s3fwrn5_fw_request_firmware(struct s3fwrn5_fw_info *fw_info)
if (ret < 0)
return ret;
if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE)
if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE) {
release_firmware(fw->fw);
return -EINVAL;
}
memcpy(fw->date, fw->fw->data + 0x00, 12);
fw->date[12] = '\0';