openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

powerpc/pseries: Initialise nvram_pstore_info's buf_lock 

nvram_pstore_info's buf_lock is not initialized before registering,
which is clearly incorrect.

It causes some strange behavior when trying to obtain the lock during
kdump process.

On a UP configuration, the console stopped for a couple of seconds, then
"lockup suspected" warning printed out, but then it continued to run.

So try lock fails, and lockup reported, but then arch_spin_lock()
passes.

Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
[mpe: Edited changelog]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Li Zhong 2014-11-17 10:52:30 +08:00 committed by Michael Ellerman
parent 35891d40bf
commit a49ab6eeeb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/platforms/pseries/nvram.c
View File

@ -715,6 +715,8 @@ static int nvram_pstore_init(void)
nvram_pstore_info.buf = oops_data; nvram_pstore_info.buf = oops_data;
nvram_pstore_info.bufsize = oops_data_sz; nvram_pstore_info.bufsize = oops_data_sz;
spin_lock_init(&nvram_pstore_info.buf_lock);
rc = pstore_register(&nvram_pstore_info); rc = pstore_register(&nvram_pstore_info);
if (rc != 0) if (rc != 0)
pr_err("nvram: pstore_register() failed, defaults to " pr_err("nvram: pstore_register() failed, defaults to "