mirror of https://gitee.com/openkylin/linux.git
dmaengine: mmp_tdma: use dmaenginem_async_device_register to simplify the code
Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister. return error if it fails. Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai> Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
parent
42f604b651
commit
a5f99a9586
|
@ -530,9 +530,6 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)
|
||||||
|
|
||||||
static int mmp_tdma_remove(struct platform_device *pdev)
|
static int mmp_tdma_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct mmp_tdma_device *tdev = platform_get_drvdata(pdev);
|
|
||||||
|
|
||||||
dma_async_device_unregister(&tdev->device);
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -696,7 +693,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
|
||||||
dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
|
dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
|
||||||
platform_set_drvdata(pdev, tdev);
|
platform_set_drvdata(pdev, tdev);
|
||||||
|
|
||||||
ret = dma_async_device_register(&tdev->device);
|
ret = dmaenginem_async_device_register(&tdev->device);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(tdev->device.dev, "unable to register\n");
|
dev_err(tdev->device.dev, "unable to register\n");
|
||||||
return ret;
|
return ret;
|
||||||
|
@ -708,7 +705,7 @@ static int mmp_tdma_probe(struct platform_device *pdev)
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(tdev->device.dev,
|
dev_err(tdev->device.dev,
|
||||||
"failed to register controller\n");
|
"failed to register controller\n");
|
||||||
dma_async_device_unregister(&tdev->device);
|
return ret;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue