openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

lightnvm: pblk: fix error handling of pblk_lines_init() 

In the too many bad blocks error handling case, we should release all
the allocated resources, otherwise it will cause memory leak.

Fixes: 2deeefc02d ("lightnvm: pblk: fail gracefully on line alloc. failure")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Wei Yongjun 2018-10-09 13:12:13 +02:00 committed by Jens Axboe
parent 6fd05cad5e
commit a70985f83c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/lightnvm/pblk-init.c
View File

@ -1024,7 +1024,8 @@ static int pblk_lines_init(struct pblk *pblk)
if (!nr_free_chks) { if (!nr_free_chks) {
pblk_err(pblk, "too many bad blocks prevent for sane instance\n"); pblk_err(pblk, "too many bad blocks prevent for sane instance\n");
return -EINTR; ret = -EINTR;
goto fail_free_lines;
} }
pblk_set_provision(pblk, nr_free_chks); pblk_set_provision(pblk, nr_free_chks);