openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ext4: fix code documentatioon 

Add a TODO to remember fixing REQ_FUA | REQ_PREFLUSH for fast commit
buffers. Also, fix a typo in top level comment in fast_commit.c

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201106035911.1942128-15-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Harshad Shirwadkar 2020-11-05 19:59:03 -08:00 committed by Theodore Ts'o
parent f6634e2609
commit a740762fb3
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ext4/fast_commit.c
View File

@ -83,7 +83,7 @@
* *
* Atomicity of commits * Atomicity of commits
* -------------------- * --------------------
* In order to gaurantee atomicity during the commit operation, fast commit * In order to guarantee atomicity during the commit operation, fast commit
* uses "EXT4_FC_TAG_TAIL" tag that marks a fast commit as complete. Tail * uses "EXT4_FC_TAG_TAIL" tag that marks a fast commit as complete. Tail
* tag contains CRC of the contents and TID of the transaction after which * tag contains CRC of the contents and TID of the transaction after which
* this fast commit should be applied. Recovery code replays fast commit * this fast commit should be applied. Recovery code replays fast commit
@ -542,6 +542,7 @@ static void ext4_fc_submit_bh(struct super_block *sb)
int write_flags = REQ_SYNC; int write_flags = REQ_SYNC;
struct buffer_head *bh = EXT4_SB(sb)->s_fc_bh; struct buffer_head *bh = EXT4_SB(sb)->s_fc_bh;
/* TODO: REQ_FUA | REQ_PREFLUSH is unnecessarily expensive. */
if (test_opt(sb, BARRIER)) if (test_opt(sb, BARRIER))
write_flags |= REQ_FUA | REQ_PREFLUSH; write_flags |= REQ_FUA | REQ_PREFLUSH;
lock_buffer(bh); lock_buffer(bh);