Merge branch 'x86-cleanups-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull x86 cleanups from Ingo Molnar:
 "Header file and a wrapper functions cleanup"

* 'x86-cleanups-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  x86: Migrate exception table users off module.h and onto extable.h
  x86: Clean up various simple wrapper functions

arch/x86/kernel/apic/apic_flat_64.c

@@ -116,27 +116,17 @@ static void flat_send_IPI_all(int vector)
 
 static unsigned int flat_get_apic_id(unsigned long x)
 {
-	unsigned int id;
+	return (x >> 24) & 0xFF;
-
-	id = (((x)>>24) & 0xFFu);
-
-	return id;
 }
 
 static unsigned long set_apic_id(unsigned int id)
 {
-	unsigned long x;
+	return (id & 0xFF) << 24;
-
-	x = ((id & 0xFFu)<<24);
-	return x;
 }
 
 static unsigned int read_xapic_id(void)
 {
-	unsigned int id;
+	return flat_get_apic_id(apic_read(APIC_ID));
-
-	id = flat_get_apic_id(apic_read(APIC_ID));
-	return id;
 }
 
 static int flat_apic_id_registered(void)

arch/x86/kernel/apic/apic_numachip.c

@@ -40,10 +40,7 @@ static unsigned int numachip1_get_apic_id(unsigned long x)
 
 static unsigned long numachip1_set_apic_id(unsigned int id)
 {
-	unsigned long x;
+	return (id & 0xff) << 24;
-
-	x = ((id & 0xffU) << 24);
-	return x;
 }
 
 static unsigned int numachip2_get_apic_id(unsigned long x)

arch/x86/kernel/apic/x2apic_uv_x.c

@@ -533,11 +533,8 @@ static unsigned int x2apic_get_apic_id(unsigned long x)
 
 static unsigned long set_apic_id(unsigned int id)
 {
-	unsigned long x;
+	/* CHECKME: Do we need to mask out the xapic extra bits? */
-
+	return id;
-	/* maskout x2apic_extra_bits ? */
-	x = id;
-	return x;
 }
 
 static unsigned int uv_read_apic_id(void)

arch/x86/kernel/kprobes/core.c

@@ -45,7 +45,7 @@
 #include <linux/slab.h>
 #include <linux/hardirq.h>
 #include <linux/preempt.h>
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <linux/kdebug.h>
 #include <linux/kallsyms.h>
 #include <linux/ftrace.h>

arch/x86/kernel/kprobes/opt.c

@@ -24,7 +24,7 @@
 #include <linux/slab.h>
 #include <linux/hardirq.h>
 #include <linux/preempt.h>
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <linux/kdebug.h>
 #include <linux/kallsyms.h>
 #include <linux/ftrace.h>

arch/x86/mm/extable.c

@@ -1,4 +1,4 @@
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <asm/uaccess.h>
 #include <asm/traps.h>
 #include <asm/kdebug.h>

arch/x86/mm/fault.c

@@ -5,7 +5,7 @@
  */
 #include <linux/sched.h>		/* test_thread_flag(), ...	*/
 #include <linux/kdebug.h>		/* oops_begin/end, ...		*/
-#include <linux/module.h>		/* search_exception_table	*/
+#include <linux/extable.h>		/* search_exception_table	*/
 #include <linux/bootmem.h>		/* max_low_pfn			*/
 #include <linux/kprobes.h>		/* NOKPROBE_SYMBOL, ...		*/
 #include <linux/mmiotrace.h>		/* kmmio_handler, ...		*/

arch/x86/mm/pat_rbtree.c

@@ -254,9 +254,7 @@ struct memtype *rbt_memtype_erase(u64 start, u64 end)
 
 struct memtype *rbt_memtype_lookup(u64 addr)
 {
-	struct memtype *data;
+	return memtype_rb_lowest_match(&memtype_rbroot, addr, addr + PAGE_SIZE);
-	data = memtype_rb_lowest_match(&memtype_rbroot, addr, addr + PAGE_SIZE);
-	return data;
 }
 
 #if defined(CONFIG_DEBUG_FS)

arch/x86/platform/uv/bios_uv.c

@@ -149,11 +149,8 @@ EXPORT_SYMBOL_GPL(uv_bios_change_memprotect);
 s64
 uv_bios_reserved_page_pa(u64 buf, u64 *cookie, u64 *addr, u64 *len)
 {
-	s64 ret;
+	return uv_bios_call_irqsave(UV_BIOS_GET_PARTITION_ADDR, (u64)cookie,
-
-	ret = uv_bios_call_irqsave(UV_BIOS_GET_PARTITION_ADDR, (u64)cookie,
 				    (u64)addr, buf, (u64)len, 0);
-	return ret;
 }
 EXPORT_SYMBOL_GPL(uv_bios_reserved_page_pa);
 

arch/x86/platform/uv/tlb_uv.c

@@ -580,11 +580,7 @@ static int uv1_wait_completion(struct bau_desc *bau_desc,
  */
 static unsigned long uv2_3_read_status(unsigned long offset, int rshft, int desc)
 {
-	unsigned long descriptor_status;
+	return ((read_lmmr(offset) >> rshft) & UV_ACT_STATUS_MASK) << 1;
-
-	descriptor_status =
-		((read_lmmr(offset) >> rshft) & UV_ACT_STATUS_MASK) << 1;
-	return descriptor_status;
 }
 
 /*