openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: fool proof dev_valid_name() 

We want to use dev_valid_name() to validate tunnel names,
so better use strnlen(name, IFNAMSIZ) than strlen(name) to make
sure to not upset KASAN.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2018-04-05 06:39:26 -07:00 committed by David S. Miller
parent 06dd3dfeea
commit a9d48205d0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/core/dev.c
View File

@ -1027,7 +1027,7 @@ bool dev_valid_name(const char *name)
{ {
if (*name == '\0') if (*name == '\0')
return false; return false;
if (strlen(name) >= IFNAMSIZ) if (strnlen(name, IFNAMSIZ) == IFNAMSIZ)
return false; return false;
if (!strcmp(name, ".") || !strcmp(name, "..")) if (!strcmp(name, ".") || !strcmp(name, ".."))
return false; return false;