openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

latency_top: Remove the ULONG_MAX stack trace hackery 

No architecture terminates the stack trace with ULONG_MAX anymore. The
consumer terminates on the first zero entry or at the number of entries, so
no functional change.

Remove the cruft.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Link: https://lkml.kernel.org/r/20190410103644.853527514@linutronix.de
This commit is contained in:
Thomas Gleixner 2019-04-10 12:28:08 +02:00
parent ead97a49ec
commit accddc41b9
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/proc/base.c
View File

@ -489,10 +489,9 @@ static int lstats_show_proc(struct seq_file *m, void *v)
lr->count, lr->time, lr->max); lr->count, lr->time, lr->max);
for (q = 0; q < LT_BACKTRACEDEPTH; q++) { for (q = 0; q < LT_BACKTRACEDEPTH; q++) {
unsigned long bt = lr->backtrace[q]; unsigned long bt = lr->backtrace[q];
if (!bt) if (!bt)
break; break;
if (bt == ULONG_MAX)
break;
seq_printf(m, " %ps", (void *)bt); seq_printf(m, " %ps", (void *)bt);
} }
seq_putc(m, '\n'); seq_putc(m, '\n');

12
kernel/latencytop.c
View File

@ -120,8 +120,8 @@ account_global_scheduler_latency(struct task_struct *tsk,
break; break;
} }
/* 0 and ULONG_MAX entries mean end of backtrace: */ /* 0 entry marks end of backtrace: */
if (record == 0 || record == ULONG_MAX) if (!record)
break; break;
} }
if (same) { if (same) {
@ -210,8 +210,8 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)
break; break;
} }
/* 0 and ULONG_MAX entries mean end of backtrace: */ /* 0 entry is end of backtrace */
if (record == 0 || record == ULONG_MAX) if (!record)
break; break;
} }
if (same) { if (same) {
@ -252,10 +252,10 @@ static int lstats_show(struct seq_file *m, void *v)
lr->count, lr->time, lr->max); lr->count, lr->time, lr->max);
for (q = 0; q < LT_BACKTRACEDEPTH; q++) { for (q = 0; q < LT_BACKTRACEDEPTH; q++) {
unsigned long bt = lr->backtrace[q]; unsigned long bt = lr->backtrace[q];
if (!bt) if (!bt)
break; break;
if (bt == ULONG_MAX)
break;
seq_printf(m, " %ps", (void *)bt); seq_printf(m, " %ps", (void *)bt);
} }
seq_puts(m, "\n"); seq_puts(m, "\n");