openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

cgroup: remove bcache_subsys_id which got added stealthily 

cafe563591 ("bcache: A block layer cache") added a new cgroup
subsystem bcache_subsys without proper review and ack.  bcache_subsys
seems to use cgroup for group stats and per-group cache_mode
configuration.  This is very much the type of usage that we don't want
to allow.

Fortunately, CONFIG_CGROUP_BCACHE which enables bcache_subsys is
currently commented out, so this shouldn't have any upstream users.
Let's nip in the bud.  While at it, clarify in cgroup_subsys.h that no
new subsystem should be added without explicit acks from cgroup
maintainers.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
Cc: cgroups@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-bcache@vger.kernel.org
This commit is contained in:
Tejun Heo 2013-07-09 16:17:39 -07:00
parent a82a729f04
commit add0c59d80
1 changed files with 7 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
include/linux/cgroup_subsys.h
View File

@ -1,86 +1,55 @@
/* Add subsystem definitions of the form SUBSYS(<name>) in this /*
* file. Surround each one by a line of comment markers so that * List of cgroup subsystems.
* patches don't collide *
* DO NOT ADD ANY SUBSYSTEM WITHOUT EXPLICIT ACKS FROM CGROUP MAINTAINERS.
*/ */
/* */
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CPUSETS) #if IS_SUBSYS_ENABLED(CONFIG_CPUSETS)
SUBSYS(cpuset) SUBSYS(cpuset)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEBUG) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEBUG)
SUBSYS(debug) SUBSYS(debug)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_SCHED) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_SCHED)
SUBSYS(cpu_cgroup) SUBSYS(cpu_cgroup)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_CPUACCT) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_CPUACCT)
SUBSYS(cpuacct) SUBSYS(cpuacct)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_MEMCG) #if IS_SUBSYS_ENABLED(CONFIG_MEMCG)
SUBSYS(mem_cgroup) SUBSYS(mem_cgroup)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEVICE) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEVICE)
SUBSYS(devices) SUBSYS(devices)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_FREEZER) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_FREEZER)
SUBSYS(freezer) SUBSYS(freezer)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_NET_CLS_CGROUP) #if IS_SUBSYS_ENABLED(CONFIG_NET_CLS_CGROUP)
SUBSYS(net_cls) SUBSYS(net_cls)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_BLK_CGROUP) #if IS_SUBSYS_ENABLED(CONFIG_BLK_CGROUP)
SUBSYS(blkio) SUBSYS(blkio)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_PERF) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_PERF)
SUBSYS(perf) SUBSYS(perf)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_NETPRIO_CGROUP) #if IS_SUBSYS_ENABLED(CONFIG_NETPRIO_CGROUP)
SUBSYS(net_prio) SUBSYS(net_prio)
#endif #endif
/* */
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_HUGETLB) #if IS_SUBSYS_ENABLED(CONFIG_CGROUP_HUGETLB)
SUBSYS(hugetlb) SUBSYS(hugetlb)
#endif #endif
/*
/* */ * DO NOT ADD ANY SUBSYSTEM WITHOUT EXPLICIT ACKS FROM CGROUP MAINTAINERS.
*/
#ifdef CONFIG_CGROUP_BCACHE
SUBSYS(bcache)
#endif
/* */