openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: wilc1000: fix return value check in wlan_initialize_threads() 

In case of error, the function kthread_run() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2016-06-17 17:34:17 +00:00 committed by Greg Kroah-Hartman
parent 4562d224ed
commit b3e6916d6e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/wilc1000/linux_wlan.c
View File

@ -715,10 +715,10 @@ static int wlan_initialize_threads(struct net_device *dev)
wilc->txq_thread = kthread_run(linux_wlan_txq_task, (void *)dev, wilc->txq_thread = kthread_run(linux_wlan_txq_task, (void *)dev,
"K_TXQ_TASK"); "K_TXQ_TASK");
if (!wilc->txq_thread) { if (IS_ERR(wilc->txq_thread)) {
netdev_err(dev, "couldn't create TXQ thread\n"); netdev_err(dev, "couldn't create TXQ thread\n");
wilc->close = 0; wilc->close = 0;
return -ENOBUFS; return PTR_ERR(wilc->txq_thread);
} }
wait_for_completion(&wilc->txq_thread_started); wait_for_completion(&wilc->txq_thread_started);