openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drivers: leds: tlc591xx: check error during device init 

The driver currently ignores errors from register writes at probe time.
It will hence register an LED class device no matter whether the
pyhsical device is present or not.

To fix this, make the device probe fail in case regmap operations
return an error.

Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Daniel Mack 2019-09-13 20:07:49 +02:00 committed by Pavel
parent fc19967bcb
commit b46d2b4d3d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/leds/leds-tlc591xx.c
View File

@ -147,7 +147,10 @@ tlc591xx_configure(struct device *dev,
unsigned int i; unsigned int i;
int err = 0; int err = 0;
tlc591xx_set_mode(priv->regmap, MODE2_DIM); err = tlc591xx_set_mode(priv->regmap, MODE2_DIM);
if (err < 0)
return err;
for (i = 0; i < TLC591XX_MAX_LEDS; i++) { for (i = 0; i < TLC591XX_MAX_LEDS; i++) {
struct tlc591xx_led *led = &priv->leds[i]; struct tlc591xx_led *led = &priv->leds[i];