mirror of https://gitee.com/openkylin/linux.git
[media] stkwebcam: don't break long lines
Due to the 80-cols restrictions, and latter due to checkpatch warnings, several strings were broken into multiple lines. This is not considered a good practice anymore, as it makes harder to grep for strings at the source code. As we're right now fixing other drivers due to KERN_CONT, we need to be able to identify what printk strings don't end with a "\n". It is a way easier to detect those if we don't break long lines. So, join those continuation lines. The patch was generated via the script below, and manually adjusted if needed. </script> use Text::Tabs; while (<>) { if ($next ne "") { $c=$_; if ($c =~ /^\s+\"(.*)/) { $c2=$1; $next =~ s/\"\n$//; $n = expand($next); $funpos = index($n, '('); $pos = index($c2, '",'); if ($funpos && $pos > 0) { $s1 = substr $c2, 0, $pos + 2; $s2 = ' ' x ($funpos + 1) . substr $c2, $pos + 2; $s2 =~ s/^\s+//; $s2 = ' ' x ($funpos + 1) . $s2 if ($s2 ne ""); print unexpand("$next$s1\n"); print unexpand("$s2\n") if ($s2 ne ""); } else { print "$next$c2\n"; } $next=""; next; } else { print $next; } $next=""; } else { if (m/\"$/) { if (!m/\\n\"$/) { $next=$_; next; } } } print $_; } </script> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
67390d21fe
commit
b4b3f99c8d
|
@ -391,8 +391,8 @@ int stk_sensor_init(struct stk_camera *dev)
|
||||||
}
|
}
|
||||||
stk_sensor_write_regvals(dev, ov_initvals);
|
stk_sensor_write_regvals(dev, ov_initvals);
|
||||||
msleep(10);
|
msleep(10);
|
||||||
STK_INFO("OmniVision sensor detected, id %02X%02X"
|
STK_INFO("OmniVision sensor detected, id %02X%02X at address %x\n",
|
||||||
" at address %x\n", idh, idl, SENSOR_ADDRESS);
|
idh, idl, SENSOR_ADDRESS);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -372,8 +372,7 @@ static void stk_isoc_handler(struct urb *urb)
|
||||||
if (fb->v4lbuf.bytesused != 0
|
if (fb->v4lbuf.bytesused != 0
|
||||||
&& fb->v4lbuf.bytesused != dev->frame_size) {
|
&& fb->v4lbuf.bytesused != dev->frame_size) {
|
||||||
(void) (printk_ratelimit() &&
|
(void) (printk_ratelimit() &&
|
||||||
STK_ERROR("frame %d, "
|
STK_ERROR("frame %d, bytesused=%d, skipping\n",
|
||||||
"bytesused=%d, skipping\n",
|
|
||||||
i, fb->v4lbuf.bytesused));
|
i, fb->v4lbuf.bytesused));
|
||||||
fb->v4lbuf.bytesused = 0;
|
fb->v4lbuf.bytesused = 0;
|
||||||
fill = fb->buffer;
|
fill = fb->buffer;
|
||||||
|
|
Loading…
Reference in New Issue