openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: gadget: bcm63xx: Re-use DEFINE_SHOW_ATTRIBUTE() macro 

...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko 2018-02-14 18:08:20 +02:00 committed by Greg Kroah-Hartman
parent efb85c4d24
commit b5c293982c
1 changed files with 4 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
drivers/usb/gadget/udc/bcm63xx_udc.c
View File

@ -2158,6 +2158,7 @@ static int bcm63xx_usbd_dbg_show(struct seq_file *s, void *p)
return 0;
}
DEFINE_SHOW_ATTRIBUTE(bcm63xx_usbd_dbg);
/*
* bcm63xx_iudma_dbg_show - Show IUDMA status and descriptors.
@ -2238,33 +2239,7 @@ static int bcm63xx_iudma_dbg_show(struct seq_file *s, void *p)
return 0;
}
static int bcm63xx_usbd_dbg_open(struct inode *inode, struct file *file)
{
return single_open(file, bcm63xx_usbd_dbg_show, inode->i_private);
}
static int bcm63xx_iudma_dbg_open(struct inode *inode, struct file *file)
{
return single_open(file, bcm63xx_iudma_dbg_show, inode->i_private);
}
static const struct file_operations usbd_dbg_fops = {
.owner = THIS_MODULE,
.open = bcm63xx_usbd_dbg_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};
static const struct file_operations iudma_dbg_fops = {
.owner = THIS_MODULE,
.open = bcm63xx_iudma_dbg_open,
.llseek = seq_lseek,
.read = seq_read,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(bcm63xx_iudma_dbg);
/**
* bcm63xx_udc_init_debugfs - Create debugfs entries.
@ -2282,11 +2257,11 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc)
goto err_root;
usbd = debugfs_create_file("usbd", 0400, root, udc,
&usbd_dbg_fops);
&bcm63xx_usbd_dbg_fops);
if (!usbd)
goto err_usbd;
iudma = debugfs_create_file("iudma", 0400, root, udc,
&iudma_dbg_fops);
&bcm63xx_iudma_dbg_fops);
if (!iudma)
goto err_iudma;