mirror of https://gitee.com/openkylin/linux.git
V4L/DVB: au0828: move dereference below sanity checks
This function has sanity checks to make sure that "dev" is non-null. I moved the dereference down below the checks. In the current code "dev" is never actually null. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Devin Heitmueller <dheitmueller@kernellabs.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
49b7a12c0a
commit
b5f5933a6a
|
@ -441,7 +441,7 @@ static void au0828_copy_vbi(struct au0828_dev *dev,
|
|||
unsigned char *outp, unsigned long len)
|
||||
{
|
||||
unsigned char *startwrite, *startread;
|
||||
int bytesperline = dev->vbi_width;
|
||||
int bytesperline;
|
||||
int i, j = 0;
|
||||
|
||||
if (dev == NULL) {
|
||||
|
@ -464,6 +464,8 @@ static void au0828_copy_vbi(struct au0828_dev *dev,
|
|||
return;
|
||||
}
|
||||
|
||||
bytesperline = dev->vbi_width;
|
||||
|
||||
if (dma_q->pos + len > buf->vb.size)
|
||||
len = buf->vb.size - dma_q->pos;
|
||||
|
||||
|
|
Loading…
Reference in New Issue