openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

selftests: mlxsw: Remove a redundant if statement in port_scale test 

Currently, the error return code of the failure condition is lost after
using an if statement, so the test doesn't fail when it should.

Remove the if statement that separates the condition and the error code
check, so the test won't always pass.

Fixes: 5154b1b826 ("selftests: mlxsw: Add a scale test for physical ports")
Reported-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Danielle Ratson 2021-04-23 14:19:44 +02:00 committed by David S. Miller
parent c8d0260cdd
commit b6fc2f2121
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testing/selftests/drivers/net/mlxsw/port_scale.sh
View File

@ -55,10 +55,6 @@ port_test()
| jq '.[][][] | select(.name=="physical_ports") |.["occ"]') | jq '.[][][] | select(.name=="physical_ports") |.["occ"]')
[[ $occ -eq $max_ports ]] [[ $occ -eq $max_ports ]]
if [[ $should_fail -eq 0 ]]; then check_err_fail $should_fail $? "Attempt to create $max_ports ports (actual result $occ)"
check_err $? "Mismatch ports number: Expected $max_ports, got $occ."
else
check_err_fail $should_fail $? "Reached more ports than expected"
fi
} }