From b771852270499d760825ebad894498b8059355a4 Mon Sep 17 00:00:00 2001 From: Christian Engelmayer Date: Fri, 23 Oct 2015 19:26:18 -0200 Subject: [PATCH] [media] as102: fix potential double free in as102_fw_upload() In case the request to locate the firmware file part 2 fails, the error path releases the already freed firmware memory location again. Thus reset the firmware pointer to NULL after releasing firmware file part 1. Signed-off-by: Christian Engelmayer Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/as102/as102_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/as102/as102_fw.c b/drivers/media/usb/as102/as102_fw.c index 07d08c49f4d4..5a28ce3a1d49 100644 --- a/drivers/media/usb/as102/as102_fw.c +++ b/drivers/media/usb/as102/as102_fw.c @@ -198,6 +198,7 @@ int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap) pr_info("%s: firmware: %s loaded with success\n", DRIVER_NAME, fw1); release_firmware(firmware); + firmware = NULL; /* wait for boot to complete */ mdelay(100);