openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

pwm: raspberrypi-poe: Simplify using devm_pwmchip_add() 

This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Uwe Kleine-König 2021-07-07 18:28:15 +02:00 committed by Thierry Reding
parent 97f290357d
commit b7783c6258
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pwm/pwm-raspberrypi-poe.c
View File

@ -166,8 +166,6 @@ static int raspberrypi_pwm_probe(struct platform_device *pdev)
rpipwm->chip.base = -1; rpipwm->chip.base = -1;
rpipwm->chip.npwm = RASPBERRYPI_FIRMWARE_PWM_NUM; rpipwm->chip.npwm = RASPBERRYPI_FIRMWARE_PWM_NUM;
platform_set_drvdata(pdev, rpipwm);
ret = raspberrypi_pwm_get_property(rpipwm->firmware, RPI_PWM_CUR_DUTY_REG, ret = raspberrypi_pwm_get_property(rpipwm->firmware, RPI_PWM_CUR_DUTY_REG,
&rpipwm->duty_cycle); &rpipwm->duty_cycle);
if (ret) { if (ret) {
@ -175,14 +173,7 @@ static int raspberrypi_pwm_probe(struct platform_device *pdev)
return ret; return ret;
} }
return pwmchip_add(&rpipwm->chip); return devm_pwmchip_add(dev, &rpipwm->chip);
}
static int raspberrypi_pwm_remove(struct platform_device *pdev)
{
struct raspberrypi_pwm *rpipwm = platform_get_drvdata(pdev);
return pwmchip_remove(&rpipwm->chip);
} }
static const struct of_device_id raspberrypi_pwm_of_match[] = { static const struct of_device_id raspberrypi_pwm_of_match[] = {
@ -197,7 +188,6 @@ static struct platform_driver raspberrypi_pwm_driver = {
.of_match_table = raspberrypi_pwm_of_match, .of_match_table = raspberrypi_pwm_of_match,
}, },
.probe = raspberrypi_pwm_probe, .probe = raspberrypi_pwm_probe,
.remove = raspberrypi_pwm_remove,
}; };
module_platform_driver(raspberrypi_pwm_driver); module_platform_driver(raspberrypi_pwm_driver);