openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[INET]: Avoid an integer divide in rt_garbage_collect() 

Since 'goal' is a signed int, compiler may emit an integer divide
to compute goal/2.

Using a right shift is OK here and less expensive.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2007-12-21 01:49:07 -08:00 committed by David S. Miller
parent 9cb5734e5b
commit b790cedd24
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv4/route.c
View File

@ -851,14 +851,14 @@ static int rt_garbage_collect(void)
equilibrium = ipv4_dst_ops.gc_thresh; equilibrium = ipv4_dst_ops.gc_thresh;
goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium; goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;
if (goal > 0) { if (goal > 0) {
equilibrium += min_t(unsigned int, goal / 2, rt_hash_mask + 1); equilibrium += min_t(unsigned int, goal >> 1, rt_hash_mask + 1);
goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium; goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;
} }
} else { } else {
/* We are in dangerous area. Try to reduce cache really /* We are in dangerous area. Try to reduce cache really
* aggressively. * aggressively.
*/ */
goal = max_t(unsigned int, goal / 2, rt_hash_mask + 1); goal = max_t(unsigned int, goal >> 1, rt_hash_mask + 1);
equilibrium = atomic_read(&ipv4_dst_ops.entries) - goal; equilibrium = atomic_read(&ipv4_dst_ops.entries) - goal;
} }