openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Staging: lustre: ptlrpc: signedness bug in high_priority_ratio_store() 

We want to store a non-negative int here.  The original code had a check
for unsigned long less than zero which is a mistake but also casting
from a positive long to an int can result in a negative number.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2015-06-05 12:22:57 +03:00 committed by Greg Kroah-Hartman
parent 02b310794b
commit b815555df8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
View File

@ -1035,9 +1035,9 @@ static ssize_t high_priority_ratio_store(struct kobject *kobj,
struct ptlrpc_service *svc = container_of(kobj, struct ptlrpc_service,
srv_kobj);
int rc;
unsigned long val;
int val;
rc = kstrtoul(buffer, 10, &val);
rc = kstrtoint(buffer, 10, &val);
if (rc < 0)
return rc;