openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: pl2303: restrict the divisor based baud rate encoding method to the "HX" chip type 

It's not clear if the type_0 and type_1 chips support the divisor based baud
rate encoding method, so don't use it until anyone with such chip has tested it
to avoid regressions with the following patches.

Even if it has been working fine with these chips since the code has been added
2 years ago, this change will not cause any regressions, because the baud rates
currently supported/allowed with the divisor based method are supported with
the direct method, too.

The code for the divisor based method also isn't entirely correct (yet), so that the
direct encoding method actually works better (sets the baud rate more precisely).

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Frank Schäfer 2013-07-30 21:49:04 +02:00 committed by Greg Kroah-Hartman
parent d4f09e28d7
commit b8bdad6082
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/serial/pl2303.c
View File

@ -305,10 +305,14 @@ static void pl2303_encode_baudrate(struct tty_struct *tty,
if (spriv->type != HX)
baud = min_t(int, baud, 1228800);
if (baud <= 115200) {
if (spriv->type != HX || baud <= 115200) {
/* Direct (standard) baud rate encoding method */
put_unaligned_le32(baud, buf);
} else {
/*
* NOTE: it's not clear if the type_0/1 chips
* support this method
*
* Apparently the formula for higher speeds is:
* baudrate = 12M * 32 / (2^buf[1]) / buf[0]
*/