openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

dm cache: avoid calling policy destructor twice on error 

If the cache policy's config values are not able to be set we must
set the policy to NULL after destroying it in create_cache_policy()
so we don't attempt to destroy it a second time later.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
This commit is contained in:
Heinz Mauelshagen 2013-03-20 17:21:26 +00:00 committed by Alasdair G Kergon
parent 617a0b89da
commit b978440b8d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/md/dm-cache-target.c
View File

@ -1763,8 +1763,11 @@ static int create_cache_policy(struct cache *cache, struct cache_args *ca,
} }
r = set_config_values(cache->policy, ca->policy_argc, ca->policy_argv); r = set_config_values(cache->policy, ca->policy_argc, ca->policy_argv);
if (r) if (r) {
*error = "Error setting cache policy's config values";
dm_cache_policy_destroy(cache->policy); dm_cache_policy_destroy(cache->policy);
cache->policy = NULL;
}
return r; return r;
} }