openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

V4L/DVB (10283): cx18: Call request_module() with proper argument types. 

request_module() needs to be called with a string literal for a
format string or with 1 or more variable arguments to avoid
compiler warnings and possible exploits, if someone could cause
us to get a format string with a '%' code in the format string
when we make the call.

Reported-by: Brandon Jenkins <bcjenkins@tvwhere.com>
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Andy Walls 2009-01-17 13:37:36 -03:00 committed by Mauro Carvalho Chehab
parent 888cdb0774
commit be411df610
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/video/cx18/cx18-driver.c
View File

@ -728,7 +728,7 @@ static u32 cx18_request_module(struct cx18 *cx, u32 hw,
{ {
if ((hw & id) == 0) if ((hw & id) == 0)
return hw; return hw;
if (request_module(name) != 0) { if (request_module("%s", name) != 0) {
CX18_ERR("Failed to load module %s\n", name); CX18_ERR("Failed to load module %s\n", name);
return hw & ~id; return hw & ~id;
} }