openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

powerpc/powernv/eeh/npu: Fix uninitialized variables in opal_pci_eeh_freeze_status 

The current implementation of the OPAL_PCI_EEH_FREEZE_STATUS call in
skiboot's NPU driver does not touch the pci_error_type parameter so
it might have garbage but the powernv code analyzes it nevertheless.

This initializes pcierr and fstate to zero in all call sites.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Sam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Alexey Kardashevskiy 2018-11-19 15:25:17 +11:00 committed by Michael Ellerman
parent a25de7af34
commit c20577014f
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/powerpc/platforms/powernv/eeh-powernv.c
View File

@ -564,8 +564,8 @@ static void pnv_eeh_get_phb_diag(struct eeh_pe *pe)
static int pnv_eeh_get_phb_state(struct eeh_pe *pe) static int pnv_eeh_get_phb_state(struct eeh_pe *pe)
{ {
struct pnv_phb *phb = pe->phb->private_data; struct pnv_phb *phb = pe->phb->private_data;
u8 fstate; u8 fstate = 0;
__be16 pcierr; __be16 pcierr = 0;
s64 rc; s64 rc;
int result = 0; int result = 0;
@ -603,8 +603,8 @@ static int pnv_eeh_get_phb_state(struct eeh_pe *pe)
static int pnv_eeh_get_pe_state(struct eeh_pe *pe) static int pnv_eeh_get_pe_state(struct eeh_pe *pe)
{ {
struct pnv_phb *phb = pe->phb->private_data; struct pnv_phb *phb = pe->phb->private_data;
u8 fstate; u8 fstate = 0;
__be16 pcierr; __be16 pcierr = 0;
s64 rc; s64 rc;
int result; int result;

4
arch/powerpc/platforms/powernv/pci-ioda.c
View File

@ -602,8 +602,8 @@ static int pnv_ioda_unfreeze_pe(struct pnv_phb *phb, int pe_no, int opt)
static int pnv_ioda_get_pe_state(struct pnv_phb *phb, int pe_no) static int pnv_ioda_get_pe_state(struct pnv_phb *phb, int pe_no)
{ {
struct pnv_ioda_pe *slave, *pe; struct pnv_ioda_pe *slave, *pe;
u8 fstate, state; u8 fstate = 0, state;
__be16 pcierr; __be16 pcierr = 0;
s64 rc; s64 rc;
/* Sanity check on PE number */ /* Sanity check on PE number */

4
arch/powerpc/platforms/powernv/pci.c
View File

@ -602,8 +602,8 @@ static void pnv_pci_handle_eeh_config(struct pnv_phb *phb, u32 pe_no)
static void pnv_pci_config_check_eeh(struct pci_dn *pdn) static void pnv_pci_config_check_eeh(struct pci_dn *pdn)
{ {
struct pnv_phb *phb = pdn->phb->private_data; struct pnv_phb *phb = pdn->phb->private_data;
u8 fstate; u8 fstate = 0;
__be16 pcierr; __be16 pcierr = 0;
unsigned int pe_no; unsigned int pe_no;
s64 rc; s64 rc;