openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging:rtl8192u: Refactor dm_dig_connect_e - Style 

The enumerated type dm_dig_connect_e is only used to group constant
values, as the actual type is never used as the type for the variables
which use the defined constants (cur_connect_state and pre_connect_state).

These two member variables have had there defined types changed to
properly reflect there usage and to permit compiler type checks to be
performed.

In addition the definition of the enumerated type has been moved above
the structure which uses the type. The typedef of the enumerated type
has been removed to clear the checkpatch issue with defining new types
and the enumerated value DIG_CONNECT_MAX has been removed since it is
never used in code.

The resulting changes are all coding style in nature and should not
impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
John Whitmore 2018-07-29 22:07:44 +01:00 committed by Greg Kroah-Hartman
parent 9888151133
commit c3575c7c56
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/staging/rtl8192u/r8192U_dm.h
View File

@ -76,6 +76,11 @@ enum dynamic_init_gain_state {
DM_STA_DIG_MAX DM_STA_DIG_MAX
}; };
enum dig_connect {
DIG_DISCONNECT = 0,
DIG_CONNECT = 1,
};
/* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */ /* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
struct dig { struct dig {
u8 dig_enable_flag; u8 dig_enable_flag;
@ -91,8 +96,8 @@ struct dig {
enum dynamic_init_gain_state dig_state; enum dynamic_init_gain_state dig_state;
enum dynamic_init_gain_state dig_highpwr_state; enum dynamic_init_gain_state dig_highpwr_state;
u8 cur_connect_state; enum dig_connect cur_connect_state;
u8 pre_connect_state; enum dig_connect pre_connect_state;
u8 curpd_thstate; u8 curpd_thstate;
u8 prepd_thstate; u8 prepd_thstate;
@ -110,12 +115,6 @@ struct dig {
long rssi_val; long rssi_val;
}; };
typedef enum tag_dig_connect_definition {
DIG_DISCONNECT = 0,
DIG_CONNECT = 1,
DIG_CONNECT_MAX
} dm_dig_connect_e;
typedef enum tag_dig_packetdetection_threshold_definition { typedef enum tag_dig_packetdetection_threshold_definition {
DIG_PD_AT_LOW_POWER = 0, DIG_PD_AT_LOW_POWER = 0,
DIG_PD_AT_NORMAL_POWER = 1, DIG_PD_AT_NORMAL_POWER = 1,