openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

tipc: eliminate potential memory leak 

In the function tipc_sk_mcast_rcv() we call refcount_dec(&skb->users)
on received sk_buffers. Since the reference counter might hit zero at
this point, we have a potential memory leak.

We fix this by replacing refcount_dec() with kfree_skb().

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jon Maloy 2017-12-11 19:11:55 +01:00 committed by David S. Miller
parent 83593010d3
commit c545a945d0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/tipc/socket.c
View File

@ -1140,7 +1140,7 @@ void tipc_sk_mcast_rcv(struct net *net, struct sk_buff_head *arrvq,
__skb_dequeue(arrvq); __skb_dequeue(arrvq);
__skb_queue_tail(inputq, skb); __skb_queue_tail(inputq, skb);
} }
refcount_dec(&skb->users); kfree_skb(skb);
spin_unlock_bh(&inputq->lock); spin_unlock_bh(&inputq->lock);
continue; continue;
} }