openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

perf session: Fix possible null pointer dereference in session.c 

cppcheck detected following warning:
[tools/perf/util/session.c:1628] -> [tools/perf/util/session.c:1632]:
 (warning) Possible null pointer dereference: session - otherwise it
 is redundant to check it against null.

In order to avoide null pointer, check the pointer before use.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Link: http://lkml.kernel.org/r/1400087618-13628-1-git-send-email-standby24x7@gmail.com
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
This commit is contained in:
Masanari Iida 2014-05-15 02:13:38 +09:00 committed by Jiri Olsa
parent 9d372ca59b
commit c5765ece8a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/perf/util/session.c
View File

@ -1625,13 +1625,14 @@ int perf_session__cpu_bitmap(struct perf_session *session,
void perf_session__fprintf_info(struct perf_session *session, FILE *fp, void perf_session__fprintf_info(struct perf_session *session, FILE *fp,
bool full) bool full)
{ {
int fd = perf_data_file__fd(session->file);
struct stat st; struct stat st;
int ret; int fd, ret;
if (session == NULL || fp == NULL) if (session == NULL || fp == NULL)
return; return;
fd = perf_data_file__fd(session->file);
ret = fstat(fd, &st); ret = fstat(fd, &st);
if (ret == -1) if (ret == -1)
return; return;