openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

pinctrl: pinctrl-at91.c: Cleaning up if unsigned is less than zero 

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Rickard Strandqvist 2014-06-26 13:26:45 +02:00 committed by Linus Walleij
parent 8708ebca74
commit ca7162add9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/pinctrl-at91.c
View File

@ -924,7 +924,7 @@ static int at91_pinctrl_parse_functions(struct device_node *np,
/* Initialise function */ /* Initialise function */
func->name = np->name; func->name = np->name;
func->ngroups = of_get_child_count(np); func->ngroups = of_get_child_count(np);
if (func->ngroups <= 0) { if (func->ngroups == 0) {
dev_err(info->dev, "no groups defined\n"); dev_err(info->dev, "no groups defined\n");
return -EINVAL; return -EINVAL;
} }