openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: coda: fix decoder capture buffer payload 

It is not correct to calculate decoder capture payload dynamically from
the decoded frame width and height reported by the firmware. These tell
us what the decoder wrote into the internal framebuffers. The rotator or
VDOA always write the full sizeimage when copying the previously decoded
frame from the internal framebuffers into the capture queue.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Philipp Zabel 2019-01-08 15:20:43 -02:00 committed by Mauro Carvalho Chehab
parent fbf9aa6aea
commit cd9f125cfa
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/media/platform/coda/coda-bit.c
View File

@ -2024,7 +2024,6 @@ static void coda_finish_decode(struct coda_ctx *ctx)
struct coda_q_data *q_data_dst; struct coda_q_data *q_data_dst;
struct vb2_v4l2_buffer *dst_buf; struct vb2_v4l2_buffer *dst_buf;
struct coda_buffer_meta *meta; struct coda_buffer_meta *meta;
unsigned long payload;
int width, height; int width, height;
int decoded_idx; int decoded_idx;
int display_idx; int display_idx;
@ -2230,21 +2229,8 @@ static void coda_finish_decode(struct coda_ctx *ctx)
trace_coda_dec_rot_done(ctx, dst_buf, meta); trace_coda_dec_rot_done(ctx, dst_buf, meta);
switch (q_data_dst->fourcc) { vb2_set_plane_payload(&dst_buf->vb2_buf, 0,
case V4L2_PIX_FMT_YUYV: q_data_dst->sizeimage);
payload = width * height * 2;
break;
case V4L2_PIX_FMT_YUV420:
case V4L2_PIX_FMT_YVU420:
case V4L2_PIX_FMT_NV12:
default:
payload = width * height * 3 / 2;
break;
case V4L2_PIX_FMT_YUV422P:
payload = width * height * 2;
break;
}
vb2_set_plane_payload(&dst_buf->vb2_buf, 0, payload);
if (ctx->frame_errors[ctx->display_idx] || err_vdoa) if (ctx->frame_errors[ctx->display_idx] || err_vdoa)
coda_m2m_buf_done(ctx, dst_buf, VB2_BUF_STATE_ERROR); coda_m2m_buf_done(ctx, dst_buf, VB2_BUF_STATE_ERROR);