openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ceph: fix dentry reference leak in ceph_encode_fh(). 

dput() was not called in the error path.

Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Reviewed-by: Alex Elder <elder@inktank.com>
This commit is contained in:
Cyril Roelandt 2012-11-20 10:23:07 -06:00 committed by Alex Elder
parent 22cddde104
commit cfc84c9f73
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ceph/export.c
View File

@ -56,13 +56,15 @@ static int ceph_encode_fh(struct inode *inode, u32 *rawfh, int *max_len,
struct ceph_nfs_confh *cfh = (void *)rawfh; struct ceph_nfs_confh *cfh = (void *)rawfh;
int connected_handle_length = sizeof(*cfh)/4; int connected_handle_length = sizeof(*cfh)/4;
int handle_length = sizeof(*fh)/4; int handle_length = sizeof(*fh)/4;
struct dentry *dentry = d_find_alias(inode); struct dentry *dentry;
struct dentry *parent; struct dentry *parent;
/* don't re-export snaps */ /* don't re-export snaps */
if (ceph_snap(inode) != CEPH_NOSNAP) if (ceph_snap(inode) != CEPH_NOSNAP)
return -EINVAL; return -EINVAL;
dentry = d_find_alias(inode);
/* if we found an alias, generate a connectable fh */ /* if we found an alias, generate a connectable fh */
if (*max_len >= connected_handle_length && dentry) { if (*max_len >= connected_handle_length && dentry) {
dout("encode_fh %p connectable\n", dentry); dout("encode_fh %p connectable\n", dentry);