Merge git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-linus

* git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-linus:
  Squashfs: frag_size should be signed, as it can hold an error result
  Squashfs: fix documentation typo, Cramfs filesystem limit is 256 MiB
  Squashfs: Fix oops when reading fsfuzzer corrupted filesystems
This commit is contained in:
Linus Torvalds 2009-03-08 10:21:31 -07:00
commit d0cdb070ce
6 changed files with 20 additions and 9 deletions

View File

@ -22,7 +22,7 @@ Squashfs filesystem features versus Cramfs:
Squashfs Cramfs Squashfs Cramfs
Max filesystem size: 2^64 16 MiB Max filesystem size: 2^64 256 MiB
Max file size: ~ 2 TiB 16 MiB Max file size: ~ 2 TiB 16 MiB
Max files: unlimited unlimited Max files: unlimited unlimited
Max directories: unlimited unlimited Max directories: unlimited unlimited

View File

@ -80,7 +80,7 @@ static struct buffer_head *get_block_length(struct super_block *sb,
* generated a larger block - this does occasionally happen with zlib). * generated a larger block - this does occasionally happen with zlib).
*/ */
int squashfs_read_data(struct super_block *sb, void **buffer, u64 index, int squashfs_read_data(struct super_block *sb, void **buffer, u64 index,
int length, u64 *next_index, int srclength) int length, u64 *next_index, int srclength, int pages)
{ {
struct squashfs_sb_info *msblk = sb->s_fs_info; struct squashfs_sb_info *msblk = sb->s_fs_info;
struct buffer_head **bh; struct buffer_head **bh;
@ -185,6 +185,14 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index,
} }
if (msblk->stream.avail_out == 0) { if (msblk->stream.avail_out == 0) {
if (page == pages) {
ERROR("zlib_inflate tried to "
"decompress too much data, "
"expected %d bytes. Zlib "
"data probably corrupt\n",
srclength);
goto release_mutex;
}
msblk->stream.next_out = buffer[page++]; msblk->stream.next_out = buffer[page++];
msblk->stream.avail_out = PAGE_CACHE_SIZE; msblk->stream.avail_out = PAGE_CACHE_SIZE;
} }
@ -268,7 +276,8 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index,
put_bh(bh[k]); put_bh(bh[k]);
read_failure: read_failure:
ERROR("sb_bread failed reading block 0x%llx\n", cur_index); ERROR("squashfs_read_data failed to read block 0x%llx\n",
(unsigned long long) index);
kfree(bh); kfree(bh);
return -EIO; return -EIO;
} }

View File

@ -119,7 +119,7 @@ struct squashfs_cache_entry *squashfs_cache_get(struct super_block *sb,
entry->length = squashfs_read_data(sb, entry->data, entry->length = squashfs_read_data(sb, entry->data,
block, length, &entry->next_index, block, length, &entry->next_index,
cache->block_size); cache->block_size, cache->pages);
spin_lock(&cache->lock); spin_lock(&cache->lock);
@ -406,7 +406,7 @@ int squashfs_read_table(struct super_block *sb, void *buffer, u64 block,
for (i = 0; i < pages; i++, buffer += PAGE_CACHE_SIZE) for (i = 0; i < pages; i++, buffer += PAGE_CACHE_SIZE)
data[i] = buffer; data[i] = buffer;
res = squashfs_read_data(sb, data, block, length | res = squashfs_read_data(sb, data, block, length |
SQUASHFS_COMPRESSED_BIT_BLOCK, NULL, length); SQUASHFS_COMPRESSED_BIT_BLOCK, NULL, length, pages);
kfree(data); kfree(data);
return res; return res;
} }

View File

@ -133,7 +133,8 @@ int squashfs_read_inode(struct inode *inode, long long ino)
type = le16_to_cpu(sqshb_ino->inode_type); type = le16_to_cpu(sqshb_ino->inode_type);
switch (type) { switch (type) {
case SQUASHFS_REG_TYPE: { case SQUASHFS_REG_TYPE: {
unsigned int frag_offset, frag_size, frag; unsigned int frag_offset, frag;
int frag_size;
u64 frag_blk; u64 frag_blk;
struct squashfs_reg_inode *sqsh_ino = &squashfs_ino.reg; struct squashfs_reg_inode *sqsh_ino = &squashfs_ino.reg;
@ -175,7 +176,8 @@ int squashfs_read_inode(struct inode *inode, long long ino)
break; break;
} }
case SQUASHFS_LREG_TYPE: { case SQUASHFS_LREG_TYPE: {
unsigned int frag_offset, frag_size, frag; unsigned int frag_offset, frag;
int frag_size;
u64 frag_blk; u64 frag_blk;
struct squashfs_lreg_inode *sqsh_ino = &squashfs_ino.lreg; struct squashfs_lreg_inode *sqsh_ino = &squashfs_ino.lreg;

View File

@ -34,7 +34,7 @@ static inline struct squashfs_inode_info *squashfs_i(struct inode *inode)
/* block.c */ /* block.c */
extern int squashfs_read_data(struct super_block *, void **, u64, int, u64 *, extern int squashfs_read_data(struct super_block *, void **, u64, int, u64 *,
int); int, int);
/* cache.c */ /* cache.c */
extern struct squashfs_cache *squashfs_cache_init(char *, int, int); extern struct squashfs_cache *squashfs_cache_init(char *, int, int);

View File

@ -389,7 +389,7 @@ static int __init init_squashfs_fs(void)
return err; return err;
} }
printk(KERN_INFO "squashfs: version 4.0 (2009/01/03) " printk(KERN_INFO "squashfs: version 4.0 (2009/01/31) "
"Phillip Lougher\n"); "Phillip Lougher\n");
return 0; return 0;