openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ftrace: fix mutex unlock in trace output 

If the trace output changes on reading the trace files, there is a chance
that the start function will return NULL. If the start function of a sequence
returns NULL the stop equivalent is not called. In this case, all locks
that are taken must be released even if they are released in the stop function.

This patch fixes a case that a mutex was not released on return of NULL
in the start sequence function.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Steven Rostedt 2008-05-12 21:20:56 +02:00 committed by Thomas Gleixner
parent 07a267cdd2
commit d15f57f23e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/trace/trace.c
View File

@ -964,8 +964,10 @@ static void *s_start(struct seq_file *m, loff_t *pos)
mutex_lock(&trace_types_lock); mutex_lock(&trace_types_lock);
if (!current_trace || current_trace != iter->trace) if (!current_trace || current_trace != iter->trace) {
mutex_unlock(&trace_types_lock);
return NULL; return NULL;
}
atomic_inc(&trace_record_cmdline_disabled); atomic_inc(&trace_record_cmdline_disabled);