openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

greybus: svc: disable connection after all its users are gone 

gb_svc_del() can be called during removal of gb-es2.ko module as well,
and in that case we would like to properly shutdown all modules and
interfaces as USB is still alive.

This requires that we don't disable the svc connection, at least for tx,
as that will be used while removing modules and interfaces.

Disable only rx to begin with, as we shouldn't be handling any requests
from the SVC. Disable tx only after all the users of svc connection are
gone.

Tested on EVT 2.0 by remove gb-es2.ko module. There are still few
errors, specially while quiescing the connections (-22), but not that
many.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-06-13 21:48:28 +05:30 committed by Greg Kroah-Hartman
parent d9e4c4ee12
commit d1a8c36ec1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/svc.c
View File

@ -1456,7 +1456,7 @@ static void gb_svc_remove_modules(struct gb_svc *svc)
void gb_svc_del(struct gb_svc *svc) void gb_svc_del(struct gb_svc *svc)
{ {
gb_connection_disable(svc->connection); gb_connection_disable_rx(svc->connection);
/* /*
* The SVC device and input device may have been registered * The SVC device and input device may have been registered
@ -1473,6 +1473,8 @@ void gb_svc_del(struct gb_svc *svc)
flush_workqueue(svc->wq); flush_workqueue(svc->wq);
gb_svc_remove_modules(svc); gb_svc_remove_modules(svc);
gb_connection_disable(svc->connection);
} }
void gb_svc_put(struct gb_svc *svc) void gb_svc_put(struct gb_svc *svc)