openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

smc91x: retrieve IRQ and trigger flags in a modern way 

The SMC91x is written to explicitly look up the IRQ resource
from the platform device and extract the IRQ and flags, however
the platform_get_irq() does additional things, like call
of_irq_get() in the device tree case, which will translate
the IRQ using the irqdomain and defer the probe if the
IRQ host cannot be found.

As we're not looking up the resource, this will not retrieve
the IRQ flags, but that is better done using
irqd_get_trigger_type(), as the trigger is what the driver
wants to modify. We take care to preserve the semantics that
will make the trigger type provided from the resource
override any local specifier.

Tested on the Nomadik NHK15 which has its SMC91x IRQ line
connected to a STMPE2401 GPIO expander on I2C.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Linus Walleij 2014-10-31 21:32:06 +01:00 committed by David S. Miller
parent 1db3ddff16
commit d52fdbb735
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/net/ethernet/smsc/smc91x.c
View File

@ -2243,9 +2243,10 @@ static int smc_drv_probe(struct platform_device *pdev)
const struct of_device_id *match = NULL; const struct of_device_id *match = NULL;
struct smc_local *lp; struct smc_local *lp;
struct net_device *ndev; struct net_device *ndev;
struct resource *res, *ires; struct resource *res;
unsigned int __iomem *addr; unsigned int __iomem *addr;
unsigned long irq_flags = SMC_IRQ_FLAGS; unsigned long irq_flags = SMC_IRQ_FLAGS;
unsigned long irq_resflags;
int ret; int ret;
ndev = alloc_etherdev(sizeof(struct smc_local)); ndev = alloc_etherdev(sizeof(struct smc_local));
@ -2337,16 +2338,19 @@ static int smc_drv_probe(struct platform_device *pdev)
goto out_free_netdev; goto out_free_netdev;
} }
ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0); ndev->irq = platform_get_irq(pdev, 0);
if (!ires) { if (ndev->irq <= 0) {
ret = -ENODEV; ret = -ENODEV;
goto out_release_io; goto out_release_io;
} }
/*
ndev->irq = ires->start; * If this platform does not specify any special irqflags, or if
* the resource supplies a trigger, override the irqflags with
if (irq_flags == -1 || ires->flags & IRQF_TRIGGER_MASK) * the trigger flags from the resource.
irq_flags = ires->flags & IRQF_TRIGGER_MASK; */
irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq));
if (irq_flags == -1 || irq_resflags & IRQF_TRIGGER_MASK)
irq_flags = irq_resflags & IRQF_TRIGGER_MASK;
ret = smc_request_attrib(pdev, ndev); ret = smc_request_attrib(pdev, ndev);
if (ret) if (ret)