openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

thermal: spear: use __maybe_unused for PM functions 

The spear thermal driver hides its suspend/resume function conditionally
based on CONFIG_PM, but references them based on CONFIG_PM_SLEEP, so
we get a warning if the former is set but the latter is not:

thermal/spear_thermal.c:58:12: warning: 'spear_thermal_suspend' defined but not used [-Wunused-function]
thermal/spear_thermal.c:75:12: warning: 'spear_thermal_resume' defined but not used [-Wunused-function]

This removes the #ifdef and instead uses a __maybe_uninitialized
annotation to avoid the warning and improve compile-time coverage.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
This commit is contained in:
Arnd Bergmann 2016-01-25 17:44:10 +01:00 committed by Eduardo Valentin
parent 8b477ea563
commit d612c64d1f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/thermal/spear_thermal.c
View File

@ -54,8 +54,7 @@ static struct thermal_zone_device_ops ops = {
.get_temp = thermal_get_temp, .get_temp = thermal_get_temp,
}; };
#ifdef CONFIG_PM static int __maybe_unused spear_thermal_suspend(struct device *dev)
static int spear_thermal_suspend(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev); struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev);
@ -72,7 +71,7 @@ static int spear_thermal_suspend(struct device *dev)
return 0; return 0;
} }
static int spear_thermal_resume(struct device *dev) static int __maybe_unused spear_thermal_resume(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev); struct thermal_zone_device *spear_thermal = platform_get_drvdata(pdev);
@ -94,7 +93,6 @@ static int spear_thermal_resume(struct device *dev)
return 0; return 0;
} }
#endif
static SIMPLE_DEV_PM_OPS(spear_thermal_pm_ops, spear_thermal_suspend, static SIMPLE_DEV_PM_OPS(spear_thermal_pm_ops, spear_thermal_suspend,
spear_thermal_resume); spear_thermal_resume);