openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

cxgb4: Check for kvzalloc allocation failure 

t4_prep_fw doesn't check for card_fw pointer before store the read data,
which could lead to a NULL pointer dereference if kvzalloc failed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
YueHaibing 2018-05-22 15:07:18 +08:00 committed by David S. Miller
parent 87e5808d52
commit d624613e42
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
View File

@ -4140,6 +4140,10 @@ static int adap_init0(struct adapter *adap)
* card * card
*/ */
card_fw = kvzalloc(sizeof(*card_fw), GFP_KERNEL); card_fw = kvzalloc(sizeof(*card_fw), GFP_KERNEL);
if (!card_fw) {
ret = -ENOMEM;
goto bye;
}
/* Get FW from from /lib/firmware/ */ /* Get FW from from /lib/firmware/ */
ret = request_firmware(&fw, fw_info->fw_mod_name, ret = request_firmware(&fw, fw_info->fw_mod_name,